spark 3.3 read by snapshot ref schema#6717
Merged
aokolnychyi merged 11 commits intoapache:masterfrom Feb 22, 2023
Merged
Conversation
namrathamyske
changed the title
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Outdated
Show resolved
Hide resolved
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks for the fix @namrathamyske ! left some comments |
Contributor
Author
|
Thanks @jackieo168 for coming up with this! |
jackieo168
reviewed
Feb 4, 2023
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java
Outdated
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Show resolved
Hide resolved
Contributor
|
@aokolnychyi you might be also interested in this because #6651 depends on this |
rdblue
reviewed
Feb 9, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 9, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
Show resolved
Hide resolved
namrathamyske
requested review from
amogh-jahagirdar and
rdblue
and removed request for
amogh-jahagirdar,
aokolnychyi,
jackye1995 and
rdblue
Contributor
Author
|
@aokolnychyi can you take a look at this ? |
jackye1995
reviewed
Feb 11, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCachedTableCatalog.java
Show resolved
Hide resolved
jackye1995
reviewed
Feb 11, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCachedTableCatalog.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Feb 11, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCachedTableCatalog.java
Outdated
Show resolved
Hide resolved
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Looking close just style and one bug in the SparkCachedTableCatalog implementation. Looking at CI, also like some spotless issues . Thanks @namrathamyske !
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCachedTableCatalog.java
Outdated
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCachedTableCatalog.java
Outdated
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCachedTableCatalog.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Feb 12, 2023
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Feb 12, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCachedTableCatalog.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Feb 12, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
approved these changes
Feb 14, 2023
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Just some nits overall LGTM
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Show resolved
Hide resolved
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 22, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCachedTableCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 22, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Feb 22, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Show resolved
Hide resolved
rdblue
reviewed
Feb 22, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java
Outdated
Show resolved
Hide resolved
Contributor
|
I should be able to review this one today as well. |
rdblue
approved these changes
Feb 22, 2023
Contributor
rdblue
left a comment
rdblue
left a comment
There was a problem hiding this comment.
I saw a couple of nits, but overall I think this is good to go.
Contributor
|
I just asked for permission to push to this branch, addressing the comments |
amogh-jahagirdar
approved these changes
Feb 22, 2023
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Thanks for addressing the nits @jackye1995 , overall this looks good to be merged from my side
aokolnychyi
reviewed
Feb 22, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCachedTableCatalog.java
Show resolved
Hide resolved
aokolnychyi
reviewed
Feb 22, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCachedTableCatalog.java
Show resolved
Hide resolved
aokolnychyi
reviewed
Feb 22, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
Show resolved
Hide resolved
aokolnychyi
reviewed
Feb 22, 2023
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
Outdated
Show resolved
Hide resolved
Contributor
|
A few minor nits and should be good to go. Thanks everyone! |
aokolnychyi
approved these changes
Feb 22, 2023
Contributor
|
Thanks, @namrathamyske and @jackye1995! Thanks for reviewing, @amogh-jahagirdar @rdblue @jackieo168! |
haizhou-zhao
pushed a commit
to haizhou-zhao/iceberg
that referenced
this pull request
Feb 23, 2023
krvikash
pushed a commit
to krvikash/iceberg
that referenced
this pull request
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #5150 we introduced read from branch or tag. There is a bug where we cannot read the snapshot specific schema changes when doing
spark.read().option("branch", <branch_name>). The fix in this PR is applied similar to #3722Still yet to add support for tag. If given a heads up for branch, will go ahead with tag
cc @jackieo168
@rdblue @jackye1995 @amogh-jahagirdar @wypoon Let me know what you think